Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update assert-json-diff version. #108

Merged
merged 1 commit into from
Feb 19, 2020

Conversation

vldm
Copy link
Contributor

@vldm vldm commented Feb 19, 2020

Hi. We are using your library in our project https://github.com/tg-rs/tg-rs

But suddenly found that CI can't pass tests.

error[E0432]: unresolved imports `assert_json_diff::Actual`, `assert_json_diff::Comparison`, `assert_json_diff::Expected`
   --> /home/vladimir/.cargo/registry/src/github.com-1ecc6299db9ec823/mockito-0.23.1/src/lib.rs:565:46
    |
565 | use assert_json_diff::{assert_json_no_panic, Actual, Comparison, Expected};
    |                                              ^^^^^^  ^^^^^^^^^^  ^^^^^^^^ no `Expected` in the root
    |                                              |       |
    |                                              |       no `Comparison` in the root
    |                                              no `Actual` in the root

error[E0061]: this function takes 3 parameters but 1 parameter was supplied
   --> /home/vladimir/.cargo/registry/src/github.com-1ecc6299db9ec823/mockito-0.23.1/src/lib.rs:680:17
    |
680 |                 assert_json_no_panic(Comparison::Include(actual, expected)).is_ok()
    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected 3 parameters

error[E0061]: this function takes 3 parameters but 1 parameter was supplied
   --> /home/vladimir/.cargo/registry/src/github.com-1ecc6299db9ec823/mockito-0.23.1/src/lib.rs:687:17
    |
687 |                 assert_json_no_panic(Comparison::Include(actual, expected)).is_ok()
    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected 3 parameters

error: aborting due to 3 previous errors

We found that source of problem was in assert-json-diff#11 library.

I have updated library in order to fix the build.
But i also found that method assert_json_no_panic is marked as #[doc(hidden)] so probably you should avoid using undocumented methods in future.

@lipanski lipanski merged commit e835414 into lipanski:master Feb 19, 2020
@lipanski
Copy link
Owner

Thanks! 🥇

You forgot to update the actual version in Cargo.toml but I commited this on top.

Released as 0.23.2

@vldm vldm deleted the vm-update-json-assert branch February 19, 2020 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants